-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing function.factor #885
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gertjanvanzwieten
force-pushed
the
factor
branch
2 times, most recently
from
October 21, 2024 15:29
004811f
to
0fa5f57
Compare
gertjanvanzwieten
force-pushed
the
factor
branch
from
October 23, 2024 08:27
0fa5f57
to
c192689
Compare
This patch modifies the hash used for the name of the function produced by evaluable.compile, in order to reuse it as nutils hash.
This patch adds a simplification for LoopSum, that promotes inflations for which the dofmaps are independent of index.
This patch removes the background colour of graphviz nodes that are not visited once. For functions that are called more then once, this helps to distinguish nodes with cached values from those that evaluate in a short time span.
gertjanvanzwieten
force-pushed
the
factor
branch
2 times, most recently
from
October 28, 2024 15:25
948761f
to
8637fd0
Compare
This patch adds the argument_degree method to evaluable arrays, which returns the highest power in a specific argument if the evaluable is polynomial in that argument; or raises a NotPolynomial error otherwise.
This patch adds function.factor and evaluable.factor for the creation of equivalent sparse polynomials. See the documentation of evaluable.factor for details.
This patch replaces the trialshapes dictionary in System, which contains only the shapes of the trial arguments, by the argshapes dictionary, which contains all of the evaluable's arguments. The reason for the change is that the broader set of arguments can be used for all sorts of argument checks prior to initiating a solve.
This patch renames the System.step parameters timetarget to timearg and historysuffix to suffix for brevity.
gertjanvanzwieten
force-pushed
the
factor
branch
from
November 1, 2024 15:34
8637fd0
to
ebd55be
Compare
joostvanzwieten
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.